7e4d9800354be8a08dba65b3f377deb6dde0ae05
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 9 | ||
| Change Parameter Type groupSearchSubTree : boolean to groupSearchSubTree : Boolean in method public searchAndBindMapGroupToScopes(baseUrl String, bindUserDn String, bindPassword String, userSearchBase String, userSearchFilter String, groupSearchBase String, groupSearchFilter String, mailAttributeName String, mailSubstitute String, mailSubstituteOverridesLdap Boolean, autoAddGroups Boolean, groupSearchSubTree Boolean, groupMaxSearchDepth int, skipSSLVerification Boolean) : LdapIdentityProviderDefinition in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Change Parameter Type autoAddGroups : boolean to autoAddGroups : Boolean in method public setAutoAddGroups(autoAddGroups Boolean) : void in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Change Parameter Type ldapConfig : HashMap<String,Object> to ldapConfig : Map<String,Object> in method protected getLdapConfigAsDefinition(ldapConfig Map<String,Object>) : String in class org.cloudfoundry.identity.uaa.config.IdentityProviderBootstrap | From | To | |
| Change Parameter Type mailSubstituteOverridesLdap : boolean to mailSubstituteOverridesLdap : Boolean in method public setMailSubstituteOverridesLdap(mailSubstituteOverridesLdap Boolean) : void in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Change Parameter Type autoAddGroups : boolean to autoAddGroups : Boolean in method public searchAndBindMapGroupToScopes(baseUrl String, bindUserDn String, bindPassword String, userSearchBase String, userSearchFilter String, groupSearchBase String, groupSearchFilter String, mailAttributeName String, mailSubstitute String, mailSubstituteOverridesLdap Boolean, autoAddGroups Boolean, groupSearchSubTree Boolean, groupMaxSearchDepth int, skipSSLVerification Boolean) : LdapIdentityProviderDefinition in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Change Parameter Type groupSearchSubTree : boolean to groupSearchSubTree : Boolean in method public setGroupSearchSubTree(groupSearchSubTree Boolean) : void in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Change Parameter Type skipSSLVerification : boolean to skipSSLVerification : Boolean in method public searchAndBindMapGroupToScopes(baseUrl String, bindUserDn String, bindPassword String, userSearchBase String, userSearchFilter String, groupSearchBase String, groupSearchFilter String, mailAttributeName String, mailSubstitute String, mailSubstituteOverridesLdap Boolean, autoAddGroups Boolean, groupSearchSubTree Boolean, groupMaxSearchDepth int, skipSSLVerification Boolean) : LdapIdentityProviderDefinition in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Change Parameter Type mailSubstituteOverridesLdap : boolean to mailSubstituteOverridesLdap : Boolean in method public searchAndBindMapGroupToScopes(baseUrl String, bindUserDn String, bindPassword String, userSearchBase String, userSearchFilter String, groupSearchBase String, groupSearchFilter String, mailAttributeName String, mailSubstitute String, mailSubstituteOverridesLdap Boolean, autoAddGroups Boolean, groupSearchSubTree Boolean, groupMaxSearchDepth int, skipSSLVerification Boolean) : LdapIdentityProviderDefinition in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Change Parameter Type skipSSLVerification : boolean to skipSSLVerification : Boolean in method public setSkipSSLVerification(skipSSLVerification Boolean) : void in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Rename Variable | 1 | ||
| Rename Variable externalGroupSet : Set<String> to defaultAuthorities : Set<String> in method public doTestNestedLdapGroupsMappedToScopes(username String, password String, expected String[]) : void in class org.cloudfoundry.identity.uaa.mock.ldap.LdapMockMvcTests | From | To | |
| Change Return Type | 5 | ||
| Change Return Type boolean to Boolean in method public isSkipSSLVerification() : Boolean in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Change Return Type boolean to Boolean in method public isGroupSearchSubTree() : Boolean in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Change Return Type boolean to Boolean in method public isAutoAddGroups() : Boolean in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Change Return Type boolean to Boolean in method public isConfigured() : Boolean in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Change Return Type boolean to Boolean in method public isMailSubstituteOverridesLdap() : Boolean in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Extract Attribute | 4 | ||
| Extract Attribute public LDAP_PROFILE_FILE_SEARCH_AND_COMPARE : String in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Extract Attribute public LDAP_PROFILE_FILE_SIMPLE_BIND : String in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Extract Attribute public LDAP_GROUP_FILE_GROUPS_MAP_TO_SCOPES : String in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Extract Attribute public LDAP_PROFILE_FILE_SEARCH_AND_BIND : String in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable properties : Map<String,Object> to map : Map<String,Object> in method protected setIfNotNull(property String, value Object, map Map<String,Object>) : void in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute webApplicationContext : XmlWebApplicationContext to mainContext : XmlWebApplicationContext in class org.cloudfoundry.identity.uaa.mock.ldap.LdapMockMvcTests | From | To | |
| Extract Variable | 2 | ||
| Extract Variable env : MockEnvironment in method public testRemovedKeystoneBootstrapIsInactive() : void from class org.cloudfoundry.identity.uaa.config.IdentityProviderBootstrapTest | From | To | |
| Extract Variable env : MockEnvironment in method public testRemovedLdapBootstrapIsInactive() : void from class org.cloudfoundry.identity.uaa.config.IdentityProviderBootstrapTest | From | To | |
| Inline Variable | 1 | ||
| Inline Variable list : String[] in method public doTestNestedLdapGroupsMappedToScopesWithDefaultScopes(username String, password String, expected String[]) : void from class org.cloudfoundry.identity.uaa.mock.ldap.LdapMockMvcTests | From | To | |
| Extract Method | 1 | ||
| Extract Method protected setIfNotNull(property String, value Object, map Map<String,Object>) : void extracted from public getLdapConfigurationEnvironment() : ConfigurableEnvironment in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type mailSubstituteOverridesLdap : boolean to mailSubstituteOverridesLdap : Boolean in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Change Attribute Type autoAddGroups : boolean to autoAddGroups : Boolean in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Change Attribute Type groupSearchSubTree : boolean to groupSearchSubTree : Boolean in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To | |
| Change Attribute Type skipSSLVerification : boolean to skipSSLVerification : Boolean in class org.cloudfoundry.identity.uaa.ldap.LdapIdentityProviderDefinition | From | To |