834701247b9464992c647fe3c870e9baedae81b2
Files Diff
- Added: 1
- Removed: 1
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type addlInfo : Map<String,Object> to autoApprovedScopes : Set<String> in method private mockClientDetailsService(id String, scope String[], autoApprovedScopes Set<String>) : QueryableResourceManager<ClientDetails> in class org.cloudfoundry.identity.uaa.oauth.UserManagedAuthzApprovalHandlerTests | From | To | |
| Change Parameter Type client : BaseClientDetails to client : ClientDetails in method private cloneClient(client ClientDetails) : BaseClientDetails in class org.cloudfoundry.identity.uaa.oauth.UaaTokenServicesTests | From | To | |
| Inline Method | 1 | ||
| Inline Method protected retainAutoApprovedScopes(requestedScopes Collection<String>, autoApprovedScopes Set<String>) : Set<String> inlined to public isApproved(authorizationRequest AuthorizationRequest, userAuthentication Authentication) : boolean in class org.cloudfoundry.identity.uaa.oauth.UserManagedAuthzApprovalHandler | From | To | |
| Rename Variable | 1 | ||
| Rename Variable approvedScopes : Collection<? extends String> to clientDetails : BaseClientDetails in method private getAutoApprovedScopes(grantType Object, tokenScopes Collection<String>, client ClientDetails) : Set<String> in class org.cloudfoundry.identity.uaa.oauth.UaaTokenServices | From | To | |
| Move Source Folder | 1 | ||
| Move Source Folder server to model | From | To | |
| Extract Variable | 1 | ||
| Extract Variable autoApproveScopes : Set<String> in method public mapRow(rs ResultSet, rowNum int) : ClientDetails from class org.cloudfoundry.identity.uaa.zone.MultitenantJdbcClientDetailsService.ClientDetailsRowMapper | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type details : ClientDetails to details : BaseClientDetails in method private mockClientDetailsService(id String, scope String[], autoApprovedScopes Set<String>) : QueryableResourceManager<ClientDetails> in class org.cloudfoundry.identity.uaa.oauth.UserManagedAuthzApprovalHandlerTests | From | To | |
| Change Variable Type approvedScopes : Collection<? extends String> to clientDetails : BaseClientDetails in method private getAutoApprovedScopes(grantType Object, tokenScopes Collection<String>, client ClientDetails) : Set<String> in class org.cloudfoundry.identity.uaa.oauth.UaaTokenServices | From | To | |
| Change Variable Type client : ClientDetails to client : BaseClientDetails in method public isApproved(authorizationRequest AuthorizationRequest, userAuthentication Authentication) : boolean in class org.cloudfoundry.identity.uaa.oauth.UserManagedAuthzApprovalHandler | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter addlInfo : Map<String,Object> to autoApprovedScopes : Set<String> in method private mockClientDetailsService(id String, scope String[], autoApprovedScopes Set<String>) : QueryableResourceManager<ClientDetails> in class org.cloudfoundry.identity.uaa.oauth.UserManagedAuthzApprovalHandlerTests | From | To |