8aee13ee94a3ad572a60f5f533f1df564bb7dcf4
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public validateClient(prototype ClientDetails, create boolean, checkAdmin boolean) : ClientDetails from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpoints to public validate(prototype ClientDetails, create boolean, checkAdmin boolean) : ClientDetails from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type clientAdminEndpoints : ClientAdminEndpoints to clientDetailsValidator : ClientDetailsValidator in method public IdentityZoneEndpoints(zoneDao IdentityZoneProvisioning, idpDao IdentityProviderProvisioning, clientRegistrationService ClientRegistrationService, clientDetailsValidator ClientDetailsValidator) in class org.cloudfoundry.identity.uaa.zone.IdentityZoneEndpoints | From | To | |
| Move Attribute | 4 | ||
| Move Attribute private VALID_GRANTS : Set<String> from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpoints to private VALID_GRANTS : Set<String> from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator | From | To | |
| Move Attribute private NON_ADMIN_VALID_AUTHORITIES : Collection<String> from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpoints to private NON_ADMIN_VALID_AUTHORITIES : Collection<String> from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator | From | To | |
| Move Attribute private NON_ADMIN_INVALID_GRANTS : Collection<String> from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpoints to private NON_ADMIN_INVALID_GRANTS : Collection<String> from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator | From | To | |
| Move Attribute private reservedClientIds : Set<String> from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpoints to private reservedClientIds : Set<String> from class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator | From | To | |
| Extract Class | 1 | ||
| Extract Class org.cloudfoundry.identity.uaa.oauth.ClientDetailsValidator from class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpoints | From | To | |
| Parameterize Variable | 6 | ||
| Parameterize Variable sca : SecurityContextAccessor to securityContextAccessor : SecurityContextAccessor in method private setSecurityContextAccessor(securityContextAccessor SecurityContextAccessor) : void in class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsTests | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute clientAdminEndpoints : ClientAdminEndpoints to clientDetailsValidator : ClientDetailsValidator in class org.cloudfoundry.identity.uaa.zone.IdentityZoneEndpoints | From | To | |
| Extract Method | 12 | ||
| Extract Method private setSecurityContextAccessor(securityContextAccessor SecurityContextAccessor) : void extracted from public testScopeIsRestrictedByCaller() : void in class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsTests | From | To | |
| Extract Method private setSecurityContextAccessor(securityContextAccessor SecurityContextAccessor) : void extracted from public implicitAndAuthorizationCodeClientIsRejectedForAdmin() : void in class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsTests | From | To | |
| Extract Method private setSecurityContextAccessor(securityContextAccessor SecurityContextAccessor) : void extracted from public testAuthorityAllowedByCaller() : void in class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsTests | From | To | |
| Extract Method private setSecurityContextAccessor(securityContextAccessor SecurityContextAccessor) : void extracted from public testChangeSecretDeniedWhenOldSecretNotProvidedEvenFormAdmin() : void in class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsTests | From | To | |
| Extract Method private setSecurityContextAccessor(securityContextAccessor SecurityContextAccessor) : void extracted from public testValidScopeIsNotRestrictedByCaller() : void in class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsTests | From | To | |
| Extract Method private setSecurityContextAccessor(securityContextAccessor SecurityContextAccessor) : void extracted from public testChangeSecretDeniedForUser() : void in class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsTests | From | To | |
| Extract Method private setSecurityContextAccessor(securityContextAccessor SecurityContextAccessor) : void extracted from public testChangeSecretByAdmin() : void in class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsTests | From | To | |
| Extract Method private setSecurityContextAccessor(securityContextAccessor SecurityContextAccessor) : void extracted from public testChangeSecretDeniedForNonAdmin() : void in class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsTests | From | To | |
| Extract Method private setSecurityContextAccessor(securityContextAccessor SecurityContextAccessor) : void extracted from public testChangeSecret() : void in class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsTests | From | To | |
| Extract Method private setSecurityContextAccessor(securityContextAccessor SecurityContextAccessor) : void extracted from public testChangeSecretDeniedWhenOldSecretNotProvided() : void in class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsTests | From | To | |
| Extract Method private setSecurityContextAccessor(securityContextAccessor SecurityContextAccessor) : void extracted from public testClientPrefixScopeIsNotRestrictedByClient() : void in class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsTests | From | To | |
| Extract Method private setSecurityContextAccessor(securityContextAccessor SecurityContextAccessor) : void extracted from public testAuthorityIsRestrictedByCaller() : void in class org.cloudfoundry.identity.uaa.oauth.ClientAdminEndpointsTests | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type clientAdminEndpoints : ClientAdminEndpoints to clientDetailsValidator : ClientDetailsValidator in class org.cloudfoundry.identity.uaa.zone.IdentityZoneEndpoints | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter clientAdminEndpoints : ClientAdminEndpoints to clientDetailsValidator : ClientDetailsValidator in method public IdentityZoneEndpoints(zoneDao IdentityZoneProvisioning, idpDao IdentityProviderProvisioning, clientRegistrationService ClientRegistrationService, clientDetailsValidator ClientDetailsValidator) in class org.cloudfoundry.identity.uaa.zone.IdentityZoneEndpoints | From | To |