aac64e84e5e58f5cfb56f0d6893e06d1fb503a33
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 14
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public testResettingAPasswordChangesCodeInForm() : void renamed to public testResettingAPassword_whenCodeIsValid_rendersTheChangePasswordForm() : void in class org.cloudfoundry.identity.uaa.login.ResetPasswordControllerMockMvcTests | From | To | |
| Rename Method public create_new_code_for_repeated_request() : void renamed to public new_code_overwrite_old_code_for_repeated_request() : void in class org.cloudfoundry.identity.uaa.login.ResetPasswordControllerMockMvcTests | From | To | |
| Rename Method public validateUserAndClient(code ExpiringCode) : ExpiringCode renamed to public checkIfUserExists(code ExpiringCode) : ExpiringCode in class org.cloudfoundry.identity.uaa.account.ResetPasswordController | From | To | |
| Rename Variable | 4 | ||
| Rename Variable change : PasswordChange to passwordChange : PasswordChange in method public resetPasswordPage(model Model, response HttpServletResponse, code String) : String in class org.cloudfoundry.identity.uaa.account.ResetPasswordController | From | To | |
| Rename Variable regexpattern : Pattern to expiringCodePattern : Pattern in method private findInRenderedPage(renderedContent String, regexPattern String) : String in class org.cloudfoundry.identity.uaa.login.ResetPasswordControllerMockMvcTests | From | To | |
| Rename Variable newCode : String to renderedCode : String in method public testResettingAPassword_whenCodeIsValid_rendersTheChangePasswordForm() : void in class org.cloudfoundry.identity.uaa.login.ResetPasswordControllerMockMvcTests | From | To | |
| Rename Variable user : UaaUser to uaaUser : UaaUser in method public resetPasswordPage(model Model, response HttpServletResponse, code String) : String in class org.cloudfoundry.identity.uaa.account.ResetPasswordController | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute private rowMapper : JdbcExpiringCodeMapper in class org.cloudfoundry.identity.uaa.codestore.JdbcExpiringCodeStore | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable content : String to renderedContent : String in method private findInRenderedPage(renderedContent String, regexPattern String) : String in class org.cloudfoundry.identity.uaa.login.ResetPasswordControllerMockMvcTests | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute select : String to selectAllFields : String in class org.cloudfoundry.identity.uaa.codestore.JdbcExpiringCodeStore | From | To | |
| Inline Variable | 1 | ||
| Inline Variable pattern : String in method public testResettingAPasswordChangesCodeInForm() : void from class org.cloudfoundry.identity.uaa.login.ResetPasswordControllerMockMvcTests | From | To | |
| Extract Method | 2 | ||
| Extract Method private isExpired(expiringCode ExpiringCode) : boolean extracted from public retrieveCode(code String) : ExpiringCode in class org.cloudfoundry.identity.uaa.codestore.InMemoryExpiringCodeStore | From | To | |
| Extract Method private findInRenderedPage(renderedContent String, regexPattern String) : String extracted from public testResettingAPasswordChangesCodeInForm() : void in class org.cloudfoundry.identity.uaa.login.ResetPasswordControllerMockMvcTests | From | To |