uaa b0e6d039da80804885ed1bfee41016fdd065470d

b0e6d039da80804885ed1bfee41016fdd065470d

Files Diff

Added: 6
Removed: 0
Renamed: 0
Modified: 12

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method private getFields(clientDetails ClientDetails) : Object[] renamed to private getInsertClientDetailsFields(clientDetails ClientDetails) : Object[] in class org.cloudfoundry.identity.uaa.zone.MultitenantJdbcClientDetailsService	From	To
Pull Up Method	14
Pull Up Method private createBaseClients(length int, grantTypes Collection<String>) : ClientDetailsModification[] from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to protected createBaseClients(length int, grantTypes Collection<String>) : ClientDetailsModification[] from class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Pull Up Method private createClient(token String, id String, grantTypes Collection<String>) : ClientDetails from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to protected createClient(token String, id String, grantTypes Collection<String>) : ClientDetails from class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Pull Up Method private getClientHttpResponse(id String) : MockHttpServletResponse from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to protected getClientHttpResponse(id String) : MockHttpServletResponse from class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Pull Up Method private getClient(id String) : ClientDetails from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to protected getClient(id String) : ClientDetails from class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Pull Up Method private createAdminClient(token String) : ClientDetails from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to protected createAdminClient(token String) : ClientDetails from class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Pull Up Method private createApprovalsLoginClient(token String) : ClientDetails from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to protected createApprovalsLoginClient(token String) : ClientDetails from class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Pull Up Method private getClientResponseAsClientDetails(response MockHttpServletResponse) : ClientDetails from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to protected getClientResponseAsClientDetails(response MockHttpServletResponse) : ClientDetails from class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Pull Up Method private createBaseClient(id String, grantTypes Collection<String>) : ClientDetailsModification from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to protected createBaseClient(id String, grantTypes Collection<String>) : ClientDetailsModification from class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Pull Up Method private createClientAdminsClient(token String) : ClientDetails from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to protected createClientAdminsClient(token String) : ClientDetails from class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Pull Up Method private createReadWriteClient(token String) : ClientDetails from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to protected createReadWriteClient(token String) : ClientDetails from class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Pull Up Method private createBaseClient(id String, grantTypes Collection<String>, authorities List<String>, scopes List<String>) : ClientDetailsModification from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to protected createBaseClient(id String, grantTypes Collection<String>, authorities List<String>, scopes List<String>) : ClientDetailsModification from class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Pull Up Method private toString(client Object) : String from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to protected toString(client Object) : String from class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Pull Up Method private toString(clients Object[]) : String from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to protected toString(clients Object[]) : String from class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Pull Up Method private makeClientName(id String) : String from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to protected makeClientName(id String) : String from class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Move Method	5
Move Method private fromString(body String, clazz Class<?>) : Object from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to public fromString(body String, clazz Class<?>) : Object from class org.cloudfoundry.identity.uaa.mock.util.ClientDetailsHelper	From	To
Move Method private clientArrayFromString(clients String) : ClientDetails[] from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to public clientArrayFromString(clients String) : ClientDetails[] from class org.cloudfoundry.identity.uaa.mock.util.ClientDetailsHelper	From	To
Move Method private createBaseClient(id String, grantTypes Collection<String>, authorities List<String>, scopes List<String>) : BaseClientDetails from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsDocs to protected createBaseClient(id String, grantTypes Collection<String>, authorities List<String>, scopes List<String>) : ClientDetailsModification from class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Move Method private arrayFromString(body String, clazz Class<?>) : Object[] from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to public arrayFromString(body String, clazz Class<?>) : Object[] from class org.cloudfoundry.identity.uaa.mock.util.ClientDetailsHelper	From	To
Move Method private clientFromString(client String) : ClientDetails from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to public clientFromString(client String) : ClientDetails from class org.cloudfoundry.identity.uaa.mock.util.ClientDetailsHelper	From	To
Rename Variable	4
Rename Variable fields : Object[] to clientDetailFieldsForUpdate : Object[] in method private getInsertClientDetailsFields(clientDetails ClientDetails) : Object[] in class org.cloudfoundry.identity.uaa.zone.MultitenantJdbcClientDetailsService	From	To
Rename Variable createdClientDetails1 : BaseClientDetails to clientDetails : BaseClientDetails in method private createBasicClientWithAdditionalInformation(scopes List<String>) : BaseClientDetails in class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsDocs	From	To
Rename Variable createdClientDetails2 : BaseClientDetails to clientDetails : BaseClientDetails in method private createBasicClientWithAdditionalInformation(scopes List<String>) : BaseClientDetails in class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsDocs	From	To
Rename Variable createdClientDetails3 : BaseClientDetails to clientDetails : BaseClientDetails in method private createBasicClientWithAdditionalInformation(scopes List<String>) : BaseClientDetails in class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsDocs	From	To
Change Return Type	1
Change Return Type BaseClientDetails to ClientDetailsModification in method protected createBaseClient(id String, grantTypes Collection<String>, authorities List<String>, scopes List<String>) : ClientDetailsModification in class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Pull Up Attribute	2
Pull Up Attribute private adminToken : String from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to protected adminToken : String from class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Pull Up Attribute private testAccounts : UaaTestAccounts from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests to protected testAccounts : UaaTestAccounts from class org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator	From	To
Extract Class	1
Extract Class org.cloudfoundry.identity.uaa.mock.util.ClientDetailsHelper from class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests	From	To
Extract Superclass	1
Extract Superclass org.cloudfoundry.identity.uaa.mock.clients.AdminClientCreator from classes [org.cloudfoundry.identity.uaa.client.ClientMetadataAdminEndpointsDocs, org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsDocs, org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsMockMvcTests]	From	To
Extract Method	4
Extract Method private createBasicClientWithAdditionalInformation(scopes List<String>) : BaseClientDetails extracted from public clientTx() : void in class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsDocs	From	To
Extract Method private createBasicClientWithAdditionalInformation(scopes List<String>) : BaseClientDetails extracted from private createClientHelper() : ResultActions in class org.cloudfoundry.identity.uaa.mock.clients.ClientAdminEndpointsDocs	From	To
Extract And Move Method	1
Extract And Move Method public setCreatedBy(createdBy String) : ClientMetadata extracted from public mapRow(rs ResultSet, rowNum int) : ClientMetadata in class org.cloudfoundry.identity.uaa.client.JdbcClientMetadataProvisioning.ClientMetadataRowMapper & moved to class org.cloudfoundry.identity.uaa.client.ClientMetadata	From	To

b0e6d039da80804885ed1bfee41016fdd065470d

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: