uaa e95105b7194421010a5a082eb40533f5148ca1d3

e95105b7194421010a5a082eb40533f5148ca1d3

Files Diff

Added: 3
Removed: 0
Renamed: 0
Modified: 6

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	1
Move And Rename Method public MfaRequiredFilter(urlFilter String, redirect String, cache RequestCache, mfaCompleteUrl String, checker MfaChecker) from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilter to public MfaUiRequiredFilter(urlFilter String, redirect String, cache RequestCache, mfaCompleteUrl String, checker MfaChecker) from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilter	From	To
Move Method	23
Move Method public next_step_mfa_not_needed() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public next_step_mfa_not_needed() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method public do_filter_mfa_in_progress() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public do_filter_mfa_in_progress() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method public next_step_mfa_completed() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public next_step_mfa_completed() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method public do_filter_mfa_completed_with_saved_request() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public do_filter_mfa_completed_with_saved_request() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method public next_step_not_authenticated() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public next_step_not_authenticated() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method public do_filter_mfa_completed_no_saved_request() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public do_filter_mfa_completed_no_saved_request() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method public next_step_mfa_in_progress() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public next_step_mfa_in_progress() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method public send_redirect() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public send_redirect() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method public authentication_log_info_uaa() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public authentication_log_info_uaa() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method public authentication_log_info_null() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public authentication_log_info_null() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method public do_filter_invalid_auth() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public do_filter_invalid_auth() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method public do_filter_mfa_required() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public do_filter_mfa_required() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method public do_filter_mfa_ok() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public do_filter_mfa_ok() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method public authentication_log_info_unknown() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public authentication_log_info_unknown() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method public do_filter_not_authenticated() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public do_filter_not_authenticated() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method protected sendRedirect(redirectUrl String, request HttpServletRequest, response HttpServletResponse) : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilter to protected sendRedirect(redirectUrl String, request HttpServletRequest, response HttpServletResponse) : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilter	From	To
Move Method protected getNextStep(request HttpServletRequest) : MfaNextStep from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilter to protected getNextStep(request HttpServletRequest) : MfaNextStep from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilter	From	To
Move Method public next_step_mfa_in_progress_when_completed_invoked() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public next_step_mfa_in_progress_when_completed_invoked() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method public next_step_mfa_required() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public next_step_mfa_required() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method public next_step_anonymous() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public next_step_anonymous() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method protected getAuthenticationLogInfo() : String from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilter to protected getAuthenticationLogInfo() : String from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilter	From	To
Move Method public next_step_mfa_in_play() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public next_step_mfa_in_play() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Method public next_step_unknown_authentication() : void from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to public next_step_unknown_authentication() : void from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Attribute	8
Move Attribute private usernameAuthentication : UsernamePasswordAuthenticationToken from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to private usernameAuthentication : UsernamePasswordAuthenticationToken from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Attribute private anonymous : AnonymousAuthenticationToken from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to private anonymous : AnonymousAuthenticationToken from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Attribute private completedMatcher : AntPathRequestMatcher from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilter to private completedMatcher : AntPathRequestMatcher from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilter	From	To
Move Attribute private cache : RequestCache from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilter to private cache : RequestCache from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilter	From	To
Move Attribute private requestCache : RequestCache from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to private requestCache : RequestCache from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Attribute private providerProvisioning : IdentityProviderProvisioning from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests to private providerProvisioning : IdentityProviderProvisioning from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests	From	To
Move Attribute private inProgressMatcher : AntPathRequestMatcher from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilter to private inProgressMatcher : AntPathRequestMatcher from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilter	From	To
Move Attribute private redirect : String from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilter to private redirect : String from class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilter	From	To
Extract Class	1
Extract Class org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilterTests from class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests	From	To
Move Class	1
Move Class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilter.MfaNextStep moved to org.cloudfoundry.identity.uaa.mfa.MfaUiRequiredFilter.MfaNextStep	From	To
Rename Attribute	1
Rename Attribute requestCache : RequestCache to mfaChecker : MfaChecker in class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests	From	To
Extract Variable	1
Extract Variable errorCode : String in method public commence(request HttpServletRequest, response HttpServletResponse, authException AuthenticationException) : void from class org.cloudfoundry.identity.uaa.oauth.UaaAuthorizationEndpoint	From	To
Extract Method	1
Extract Method public setAuthentication(session MockHttpSession, developer ScimUser, authMethods String...) : void extracted from public setAuthentication(session MockHttpSession, developer ScimUser) : void in class org.cloudfoundry.identity.uaa.mock.token.TokenMvcMockTests	From	To
Change Attribute Type	2
Change Attribute Type requestCache : RequestCache to mfaChecker : MfaChecker in class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests	From	To
Change Attribute Type response : HttpServletResponse to response : MockHttpServletResponse in class org.cloudfoundry.identity.uaa.mfa.MfaRequiredFilterTests	From	To

e95105b7194421010a5a082eb40533f5148ca1d3

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: