uaa fcc2170cc813a4e747893e5112b33cde43bfa1f9

fcc2170cc813a4e747893e5112b33cde43bfa1f9

Files Diff

Added: 0
Removed: 0
Renamed: 0
Modified: 2

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Variable	6
Rename Variable allowedIdps : List<String> to allowedIdentityProviderKeys : List<String> in method private login(model Model, principal Principal, excludedPrompts List<String>, jsonResponse boolean, request HttpServletRequest) : String in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To
Rename Variable hintIdps : List<Map.Entry<String,AbstractIdentityProviderDefinition>> to hintIdentityProviders : List<Map.Entry<String,AbstractIdentityProviderDefinition>> in method private evaluateLoginHint(model Model, session HttpSession, samlIdentityProviders Map<String,SamlIdentityProviderDefinition>, oauthIdentityProviders Map<String,AbstractXOAuthIdentityProviderDefinition>, allIdentityProviders Map<String,AbstractIdentityProviderDefinition>, allowedIdentityProviderKeys List<String>) : Map.Entry<String,AbstractIdentityProviderDefinition> in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To
Rename Variable samlIdps : Map<String,SamlIdentityProviderDefinition> to samlIdentityProviders : Map<String,SamlIdentityProviderDefinition> in method private login(model Model, principal Principal, excludedPrompts List<String>, jsonResponse boolean, request HttpServletRequest) : String in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To
Rename Variable oauthIdentityProviderDefinitions : Map<String,AbstractXOAuthIdentityProviderDefinition> to oauthIdentityProviders : Map<String,AbstractXOAuthIdentityProviderDefinition> in method private login(model Model, principal Principal, excludedPrompts List<String>, jsonResponse boolean, request HttpServletRequest) : String in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To
Rename Variable combinedIdps : Map<String,AbstractIdentityProviderDefinition> to allIdentityProviders : Map<String,AbstractIdentityProviderDefinition> in method private login(model Model, principal Principal, excludedPrompts List<String>, jsonResponse boolean, request HttpServletRequest) : String in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To
Rename Variable matchingIdps : List<Map.Entry<String,AbstractIdentityProviderDefinition>> to matchingIdentityProviders : List<Map.Entry<String,AbstractIdentityProviderDefinition>> in method private evaluateLoginHint(model Model, session HttpSession, samlIdentityProviders Map<String,SamlIdentityProviderDefinition>, oauthIdentityProviders Map<String,AbstractXOAuthIdentityProviderDefinition>, allIdentityProviders Map<String,AbstractIdentityProviderDefinition>, allowedIdentityProviderKeys List<String>) : Map.Entry<String,AbstractIdentityProviderDefinition> in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To
Parameterize Variable	7
Parameterize Variable samlIdps : Map<String,SamlIdentityProviderDefinition> to samlIdentityProviders : Map<String,SamlIdentityProviderDefinition> in method private updateLoginPageModel(model Model, request HttpServletRequest, clientName String, samlIdentityProviders Map<String,SamlIdentityProviderDefinition>, oauthIdentityProviders Map<String,AbstractXOAuthIdentityProviderDefinition>, fieldUsernameShow boolean, linkCreateAccountShow boolean) : void in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To
Parameterize Variable samlIdps : Map<String,SamlIdentityProviderDefinition> to samlIdentityProviders : Map<String,SamlIdentityProviderDefinition> in method private setJsonInfo(model Model, samlIdentityProviders Map<String,SamlIdentityProviderDefinition>, zonifiedEntityID String, links Map) : void in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To
Parameterize Variable allowedIdps : List<String> to allowedIdentityProviderKeys : List<String> in method private evaluateLoginHint(model Model, session HttpSession, samlIdentityProviders Map<String,SamlIdentityProviderDefinition>, oauthIdentityProviders Map<String,AbstractXOAuthIdentityProviderDefinition>, allIdentityProviders Map<String,AbstractIdentityProviderDefinition>, allowedIdentityProviderKeys List<String>) : Map.Entry<String,AbstractIdentityProviderDefinition> in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To
Parameterize Variable combinedIdps : Map<String,AbstractIdentityProviderDefinition> to allIdentityProviders : Map<String,AbstractIdentityProviderDefinition> in method private evaluateLoginHint(model Model, session HttpSession, samlIdentityProviders Map<String,SamlIdentityProviderDefinition>, oauthIdentityProviders Map<String,AbstractXOAuthIdentityProviderDefinition>, allIdentityProviders Map<String,AbstractIdentityProviderDefinition>, allowedIdentityProviderKeys List<String>) : Map.Entry<String,AbstractIdentityProviderDefinition> in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To
Parameterize Variable defaultIdentityProvider : String to defaultIdentityProviderName : String in method private evaluateIdpDiscovery(model Model, samlIdentityProviders Map<String,SamlIdentityProviderDefinition>, oauthIdentityProviders Map<String,AbstractXOAuthIdentityProviderDefinition>, allIdentityProviders Map<String,AbstractIdentityProviderDefinition>, allowedIdentityProviderKeys List<String>, idpForRedirect Map.Entry<String,AbstractIdentityProviderDefinition>, discoveryEnabled boolean, discoveryPerformed boolean, defaultIdentityProviderName String) : Map.Entry<String,AbstractIdentityProviderDefinition> in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To
Parameterize Variable oauthIdentityProviderDefinitions : Map<String,AbstractXOAuthIdentityProviderDefinition> to oauthIdentityProviders : Map<String,AbstractXOAuthIdentityProviderDefinition> in method private updateLoginPageModel(model Model, request HttpServletRequest, clientName String, samlIdentityProviders Map<String,SamlIdentityProviderDefinition>, oauthIdentityProviders Map<String,AbstractXOAuthIdentityProviderDefinition>, fieldUsernameShow boolean, linkCreateAccountShow boolean) : void in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To
Parameterize Variable allowedIdps : List<String> to allowedIdentityProviderKeys : List<String> in method private evaluateIdpDiscovery(model Model, samlIdentityProviders Map<String,SamlIdentityProviderDefinition>, oauthIdentityProviders Map<String,AbstractXOAuthIdentityProviderDefinition>, allIdentityProviders Map<String,AbstractIdentityProviderDefinition>, allowedIdentityProviderKeys List<String>, idpForRedirect Map.Entry<String,AbstractIdentityProviderDefinition>, discoveryEnabled boolean, discoveryPerformed boolean, defaultIdentityProviderName String) : Map.Entry<String,AbstractIdentityProviderDefinition> in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To
Extract Method	5
Extract Method private evaluateLoginHint(model Model, session HttpSession, samlIdentityProviders Map<String,SamlIdentityProviderDefinition>, oauthIdentityProviders Map<String,AbstractXOAuthIdentityProviderDefinition>, allIdentityProviders Map<String,AbstractIdentityProviderDefinition>, allowedIdentityProviderKeys List<String>) : Map.Entry<String,AbstractIdentityProviderDefinition> extracted from private login(model Model, principal Principal, excludedPrompts List<String>, jsonResponse boolean, request HttpServletRequest) : String in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To
Extract Method private setJsonInfo(model Model, samlIdentityProviders Map<String,SamlIdentityProviderDefinition>, zonifiedEntityID String, links Map) : void extracted from private login(model Model, principal Principal, excludedPrompts List<String>, jsonResponse boolean, request HttpServletRequest) : String in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To
Extract Method private getUnauthenticatedRedirect(model Model, request HttpServletRequest, discoveryEnabled boolean, discoveryPerformed boolean) : String extracted from private login(model Model, principal Principal, excludedPrompts List<String>, jsonResponse boolean, request HttpServletRequest) : String in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To
Extract Method private evaluateIdpDiscovery(model Model, samlIdentityProviders Map<String,SamlIdentityProviderDefinition>, oauthIdentityProviders Map<String,AbstractXOAuthIdentityProviderDefinition>, allIdentityProviders Map<String,AbstractIdentityProviderDefinition>, allowedIdentityProviderKeys List<String>, idpForRedirect Map.Entry<String,AbstractIdentityProviderDefinition>, discoveryEnabled boolean, discoveryPerformed boolean, defaultIdentityProviderName String) : Map.Entry<String,AbstractIdentityProviderDefinition> extracted from private login(model Model, principal Principal, excludedPrompts List<String>, jsonResponse boolean, request HttpServletRequest) : String in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To
Extract Method private updateLoginPageModel(model Model, request HttpServletRequest, clientName String, samlIdentityProviders Map<String,SamlIdentityProviderDefinition>, oauthIdentityProviders Map<String,AbstractXOAuthIdentityProviderDefinition>, fieldUsernameShow boolean, linkCreateAccountShow boolean) : void extracted from private login(model Model, principal Principal, excludedPrompts List<String>, jsonResponse boolean, request HttpServletRequest) : String in class org.cloudfoundry.identity.uaa.login.LoginInfoEndpoint	From	To

fcc2170cc813a4e747893e5112b33cde43bfa1f9

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: