b5e60e04fe891ff271448b611aebaa6455669f5b
Files Diff
- Added: 17
- Removed: 10
- Renamed: 0
- Modified: 35
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public setCursor(cursor Optional<String>) : void from class org.apache.usergrid.corepersistence.pipeline.DataPipeline to public withCursor(cursor Optional<String>) : ReadPipelineBuilder from class org.apache.usergrid.corepersistence.pipeline.read.ReadPipelineBuilderImpl | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type query : Query to query : String in method public AbstractElasticSearchFilter(entityIndexFactory EntityIndexFactory, metricsFactory MetricsFactory, query String) in class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.AbstractElasticSearchFilter | From | To | |
| Change Parameter Type query : Query to query : String in method public ElasticSearchQueryExecutor(resultsLoaderFactory ResultsLoaderFactory, entityIndex ApplicationEntityIndex, applicationScope ApplicationScope, indexScope SearchEdge, types SearchTypes, query String, setOffsetFromCursor Optional<Integer>, limit int) in class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.impl.ElasticSearchQueryExecutor | From | To | |
| Change Parameter Type query : Query to query : String in method public ConnectionElasticSearchFilter(entityIndexFactory EntityIndexFactory, metricsFactory MetricsFactory, query String, connectionName String, connectedEntityType Optional<String>) in class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.ConnectionElasticSearchFilter | From | To | |
| Change Parameter Type resultsObservable : Observable<Results> to resultsObservable : Observable<PipelineResult<ResultsPage>> in method public ObservableQueryExecutor(resultsObservable Observable<PipelineResult<ResultsPage>>) in class org.apache.usergrid.corepersistence.results.ObservableQueryExecutor | From | To | |
| Move Attribute | 9 | ||
| Move Attribute private entityCollectionManagerFactory : EntityCollectionManagerFactory from class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.QueryConnectionElasticSearchCollectorFilter to private entityCollectionManagerFactory : EntityCollectionManagerFactory from class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.CandidateResultsEntityResultsCollector | From | To | |
| Move Attribute private entityIndexFactory : EntityIndexFactory from class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.QueryCollectionElasticSearchCollectorFilter to private entityIndexFactory : EntityIndexFactory from class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.CandidateResultsEntityResultsCollector | From | To | |
| Move Attribute private entityIndexFactory : EntityIndexFactory from class org.apache.usergrid.corepersistence.pipeline.read.ReadFilterFactoryImpl to private entityIndexFactory : EntityIndexFactory from class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.CandidateResultsEntityResultsCollector | From | To | |
| Move Attribute protected applicationScope : ApplicationScope from class org.apache.usergrid.corepersistence.pipeline.read.AbstractFilter to private applicationScope : ApplicationScope from class org.apache.usergrid.corepersistence.pipeline.read.ReadPipelineBuilderImpl | From | To | |
| Move Attribute private entityCollectionManagerFactory : EntityCollectionManagerFactory from class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.QueryCollectionElasticSearchCollectorFilter to private entityCollectionManagerFactory : EntityCollectionManagerFactory from class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.CandidateResultsEntityResultsCollector | From | To | |
| Move Attribute private entityCollectionManagerFactory : EntityCollectionManagerFactory from class org.apache.usergrid.corepersistence.pipeline.read.ReadFilterFactoryImpl to private entityCollectionManagerFactory : EntityCollectionManagerFactory from class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.CandidateResultsEntityResultsCollector | From | To | |
| Move Attribute private limit : int from class org.apache.usergrid.corepersistence.pipeline.DataPipeline to private limit : int from class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.impl.ElasticSearchQueryExecutor | From | To | |
| Move Attribute private applicationScope : ApplicationScope from class org.apache.usergrid.corepersistence.pipeline.DataPipeline to private applicationScope : ApplicationScope from class org.apache.usergrid.corepersistence.pipeline.read.ReadPipelineBuilderImpl | From | To | |
| Move Attribute private entityIndexFactory : EntityIndexFactory from class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.QueryConnectionElasticSearchCollectorFilter to private entityIndexFactory : EntityIndexFactory from class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.CandidateResultsEntityResultsCollector | From | To | |
| Extract Class | 3 | ||
| Extract Class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.CandidateResultsEntityResultsCollector from class org.apache.usergrid.corepersistence.pipeline.read.ReadFilterFactoryImpl | From | To | |
| Extract Class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.CandidateResultsEntityResultsCollector from class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.QueryCollectionElasticSearchCollectorFilter | From | To | |
| Extract Class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.CandidateResultsEntityResultsCollector from class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.QueryConnectionElasticSearchCollectorFilter | From | To | |
| Rename Class | 4 | ||
| Rename Class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.AbstractQueryElasticSearchCollectorFilter renamed to org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.AbstractElasticSearchFilter | From | To | |
| Rename Class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.QueryConnectionElasticSearchCollectorFilter renamed to org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.ConnectionElasticSearchFilter | From | To | |
| Rename Class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.QueryCollectionElasticSearchCollectorFilter renamed to org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.CollectionElasticSearchFilter | From | To | |
| Rename Class org.apache.usergrid.corepersistence.pipeline.read.TraverseFilter renamed to org.apache.usergrid.corepersistence.pipeline.read.CandidateResultsFilter | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type resultsObservable : Observable<Results> to resultsObservable : Observable<PipelineResult<ResultsPage>> in method public searchConnectedEntities(query Query) : Results in class org.apache.usergrid.corepersistence.CpRelationManager | From | To | |
| Change Variable Type resultsObservable : Observable<Results> to resultsObservable : Observable<PipelineResult<ResultsPage>> in method public searchCollection(collName String, query Query) : Results in class org.apache.usergrid.corepersistence.CpRelationManager | From | To | |
| Change Variable Type cursor : String to cursor : Optional<String> in method public testCursors() : void in class org.apache.usergrid.corepersistence.pipeline.cursor.CursorTest | From | To | |
| Rename Method | 2 | ||
| Rename Method public getOffset() : Optional<Integer> renamed to public getCursor() : Optional<String> in class org.apache.usergrid.persistence.Query | From | To | |
| Rename Method public setOffsetFromCursor(cursor String) : void renamed to public setCursor(cursor String) : void in class org.apache.usergrid.persistence.Query | From | To | |
| Inline Method | 1 | ||
| Inline Method public clearOffset() : void inlined to public setCursor(cursor String) : void in class org.apache.usergrid.persistence.Query | From | To | |
| Change Return Type | 6 | ||
| Change Return Type int to Optional<Integer> in method public getLimit(defaultLimit int) : Optional<Integer> in class org.apache.usergrid.persistence.Query | From | To | |
| Change Return Type String to Optional<String> in method public encodeAsString() : Optional<String> in class org.apache.usergrid.corepersistence.pipeline.cursor.ResponseCursor | From | To | |
| Change Return Type Observable<Results> to Observable<CandidateResults> in method public call(observable Observable<Id>) : Observable<CandidateResults> in class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.AbstractElasticSearchFilter | From | To | |
| Change Return Type Optional<Integer> to Optional<String> in method public getCursor() : Optional<String> in class org.apache.usergrid.persistence.Query | From | To | |
| Change Return Type void to ReadPipelineBuilder in method public withCursor(cursor Optional<String>) : ReadPipelineBuilder in class org.apache.usergrid.corepersistence.pipeline.read.ReadPipelineBuilderImpl | From | To | |
| Change Return Type int to Optional<Integer> in method public getLimit() : Optional<Integer> in class org.apache.usergrid.persistence.Query | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute originalLimit : int to limit : int in method private loadNextPage() : void in class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.impl.ElasticSearchQueryExecutor | From | To | |
| Extract Superclass | 2 | ||
| Extract Superclass org.apache.usergrid.corepersistence.pipeline.read.AbstractSeekingFilter from classes [org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.AbstractElasticSearchFilter, org.apache.usergrid.corepersistence.pipeline.read.graph.AbstractReadGraphFilter, org.apache.usergrid.corepersistence.pipeline.read.graph.ReadGraphConnectionByTypeFilter] | From | To | |
| Extract Superclass org.apache.usergrid.corepersistence.pipeline.read.AbstractPipelineOperation from classes [org.apache.usergrid.corepersistence.pipeline.read.entity.EntityIdFilter, org.apache.usergrid.corepersistence.pipeline.read.graph.AbstractReadGraphEdgeByIdFilter] | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute offset : Optional<Integer> to cursor : Optional<String> in class org.apache.usergrid.persistence.Query | From | To | |
| Rename Attribute entityCollectionManagerFactory : EntityCollectionManagerFactory to connectedEntityType : Optional<String> in class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.ConnectionElasticSearchFilter | From | To | |
| Rename Attribute applicationEntityIndex : EntityIndexFactory to entityIndexFactory : EntityIndexFactory in class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.AbstractElasticSearchFilter | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type limit : Optional<Integer> to limit : int in class org.apache.usergrid.corepersistence.pipeline.read.ReadPipelineBuilderImpl | From | To | |
| Change Attribute Type offset : Optional<Integer> to cursor : Optional<String> in class org.apache.usergrid.persistence.Query | From | To | |
| Change Attribute Type query : Query to query : String in class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.impl.ElasticSearchQueryExecutor | From | To | |
| Change Attribute Type query : Query to query : String in class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.AbstractElasticSearchFilter | From | To | |
| Change Attribute Type entityCollectionManagerFactory : EntityCollectionManagerFactory to connectedEntityType : Optional<String> in class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.ConnectionElasticSearchFilter | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter incomingId : Id to id : Id in method protected abstract getSearchEdge(id Id) : SearchEdge in class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.AbstractElasticSearchFilter | From | To | |
| Rename Parameter idObservable : Observable<Id> to observable : Observable<Id> in method public call(observable Observable<Id>) : Observable<CandidateResults> in class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.AbstractElasticSearchFilter | From | To | |
| Rename Parameter applicationEntityIndex : EntityIndexFactory to entityIndexFactory : EntityIndexFactory in method public AbstractElasticSearchFilter(entityIndexFactory EntityIndexFactory, metricsFactory MetricsFactory, query String) in class org.apache.usergrid.corepersistence.pipeline.read.elasticsearch.AbstractElasticSearchFilter | From | To |