50d5faf359a8193d5790aefb8269b896d9fc2feb
Files Diff
- Added: 4
- Removed: 1
- Renamed: 0
- Modified: 22
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Merge Attribute | 1 | ||
| Merge Attribute [useDecompression : boolean, serverUpgradeSettings : Http2Settings, upgrade : boolean] to useCompression : boolean in class io.vertx.core.http.impl.VertxHttp2ConnectionHandlerBuilder | From | To | |
| Move And Rename Method | 2 | ||
| Move And Rename Method public testUpgradeToClearText() : void from class io.vertx.test.core.Http2ServerTest to public testServerConnectionClosed() : void from class io.vertx.test.core.HttpMetricsTestBase | From | To | |
| Move And Rename Method private testServerConnectionClosed(protocol HttpVersion) : void from class io.vertx.test.core.HttpMetricsTest to public testUpgradeToClearTextPartialFailure() : void from class io.vertx.test.core.Http2ServerTest | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method package requestHandler(handler Handler<HttpServerRequest>) : void moved from class io.vertx.core.http.impl.Http1xServerConnection to class io.vertx.test.core.Http1xTest & inlined to public testServerConnectionExceptionHandler() : void | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type handler : Handler<ServerWebSocket> to handlers : HttpHandlers in method package wsHandler(handshaker WebSocketServerHandshaker, handlers HttpHandlers) : void in class io.vertx.core.http.impl.Http1xServerConnection | From | To | |
| Extract Variable | 1 | ||
| Extract Variable ctx : ContextInternal in method public channelInactive(chctx ChannelHandlerContext) : void from class io.vertx.core.http.impl.VertxHttp2ConnectionHandler | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type conn : HttpClientConnection to conn : HttpConnection in method private connected(headersHandler Handler<HttpVersion>, stream HttpClientStream) : void in class io.vertx.core.http.impl.HttpClientRequestImpl | From | To | |
| Change Variable Type conn : Http1xServerConnection to conn : ConnectionBase in method private actualClose(closeContext ContextInternal, done Handler<AsyncResult<Void>>) : void in class io.vertx.core.http.impl.HttpServerImpl | From | To | |
| Change Variable Type stream : Http2Stream to stream : Http2ClientStream in method public createStream(completionHandler Handler<AsyncResult<HttpClientStream>>) : void in class io.vertx.core.http.impl.Http2ClientConnection | From | To | |
| Extract Method | 2 | ||
| Extract Method private createStream(upgrade boolean, streamId int) : Http2ClientStream extracted from public createStream(completionHandler Handler<AsyncResult<HttpClientStream>>) : void in class io.vertx.core.http.impl.Http2ClientConnection | From | To | |
| Extract Method private createRequest(streamId int, headers Http2Headers) : Http2ServerRequestImpl extracted from public onHeadersRead(ctx ChannelHandlerContext, streamId int, headers Http2Headers, padding int, endOfStream boolean) : void in class io.vertx.core.http.impl.Http2ServerConnection | From | To | |
| Rename Method | 3 | ||
| Rename Method private setHandler(holder HandlerHolder<HttpHandlers>, upgrade Http2Settings, ch Channel) : VertxHttp2ConnectionHandler<Http2ServerConnection> renamed to private buildHttp2ConnectionHandler(holder HandlerHolder<HttpHandlers>) : VertxHttp2ConnectionHandler<Http2ServerConnection> in class io.vertx.core.http.impl.HttpServerImpl | From | To | |
| Rename Method public writeHeadWithContent(method HttpMethod, rawMethod String, uri String, headers MultiMap, hostHeader String, chunked boolean, content ByteBuf, end boolean) : void renamed to public writeHead(method HttpMethod, rawMethod String, uri String, headers MultiMap, hostHeader String, chunked boolean, content ByteBuf, end boolean) : void in class io.vertx.core.http.impl.Http2ClientConnection.Http2ClientStream | From | To | |
| Rename Method public writeHeadWithContent(method HttpMethod, rawMethod String, uri String, headers MultiMap, hostHeader String, chunked boolean, buf ByteBuf, end boolean) : void renamed to public writeHead(method HttpMethod, rawMethod String, uri String, headers MultiMap, hostHeader String, chunked boolean, buf ByteBuf, end boolean) : void in class io.vertx.core.http.impl.HttpClientStream | From | To | |
| Rename Variable | 2 | ||
| Rename Variable req : Http2ServerRequestImpl to request : Http2ServerRequestImpl in method private createRequest(streamId int, headers Http2Headers) : Http2ServerRequestImpl in class io.vertx.core.http.impl.Http2ServerConnection | From | To | |
| Rename Variable s : Http2Stream to stream : Http2Stream in method private createRequest(streamId int, headers Http2Headers) : Http2ServerRequestImpl in class io.vertx.core.http.impl.Http2ServerConnection | From | To | |
| Change Return Type | 1 | ||
| Change Return Type HttpClientConnection to HttpConnection in method public connection() : HttpConnection in class io.vertx.core.http.impl.HttpClientStream | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute requesthHandler : Handler<HttpServerRequest> to requestHandler : Handler<HttpServerRequest> in class io.vertx.core.http.impl.HttpHandlers | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type connectionMap : Map<Channel,Http1xServerConnection> to connectionMap : Map<Channel,ConnectionBase> in class io.vertx.core.http.impl.HttpServerImpl | From | To | |
| Change Attribute Type conn : HttpClientConnection to conn : HttpConnection in class io.vertx.core.http.impl.HttpClientResponseImpl | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public createHttp2ConnectionHandler(client HttpClientImpl, queueMetric Object, listener ConnectionListener<HttpClientConnection>, context ContextInternal, c BiConsumer<Http2ClientConnection,Long>) : VertxHttp2ConnectionHandler<Http2ClientConnection> extracted from private http2Connected(listener ConnectionListener<HttpClientConnection>, context ContextInternal, ch Channel) : void in class io.vertx.core.http.impl.HttpChannelConnector & moved to class io.vertx.core.http.impl.Http2ClientConnection | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter requesthHandler : Handler<HttpServerRequest> to requestHandler : Handler<HttpServerRequest> in method public HttpHandlers(requestHandler Handler<HttpServerRequest>, wsHandler Handler<ServerWebSocket>, connectionHandler Handler<HttpConnection>, exceptionHandler Handler<Throwable>) in class io.vertx.core.http.impl.HttpHandlers | From | To | |
| Rename Parameter ctx : ChannelHandlerContext to chctx : ChannelHandlerContext in method public channelInactive(chctx ChannelHandlerContext) : void in class io.vertx.core.http.impl.VertxHttp2ConnectionHandler | From | To | |
| Rename Parameter handler : Handler<ServerWebSocket> to handlers : HttpHandlers in method package wsHandler(handshaker WebSocketServerHandshaker, handlers HttpHandlers) : void in class io.vertx.core.http.impl.Http1xServerConnection | From | To |