5d25b25b642e5d92a4b8ce08af9ed4e5f3bdb8c3
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 15
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private checkPending() : void renamed to private nextTask() : Runnable in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Rename Method private closeConnection(holder Holder<C>) : void renamed to private evictConnection(holder Holder) : void in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method private initConnection(holder Holder<C>, context ContextInternal, concurrency long, conn C, channel Channel, weight long) : void from class io.vertx.core.http.impl.pool.Pool to private init(concurrency long, conn C, weight long) : void from class io.vertx.core.http.impl.pool.Pool.Holder | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method public deactivate(conn HttpClientConnection) : void moved from class io.vertx.core.http.impl.HttpChannelConnector to class io.vertx.core.http.impl.pool.Pool & inlined to private recycleConnection(holder Holder, timestamp long) : boolean | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type holder : Holder<C> to holder : Holder in method private evictConnection(holder Holder) : void in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Change Parameter Type conn : Holder<C> to holder : Holder in method private recycleConnection(holder Holder, timestamp long) : boolean in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Change Parameter Type connectionAdded : BiConsumer<Channel,C> to connectionAdded : Consumer<C> in method public Pool(context Context, connector ConnectionProvider<C>, queueMaxSize int, initialWeight long, maxWeight long, poolClosed Handler<Void>, connectionAdded Consumer<C>, connectionRemoved Consumer<C>, fifo boolean) in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Change Parameter Type connectionRemoved : BiConsumer<Channel,C> to connectionRemoved : Consumer<C> in method public Pool(context Context, connector ConnectionProvider<C>, queueMaxSize int, initialWeight long, maxWeight long, poolClosed Handler<Void>, connectionAdded Consumer<C>, connectionRemoved Consumer<C>, fifo boolean) in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Rename Variable | 1 | ||
| Rename Variable copy : List<Holder<C>> to toClose : List<C> in method public closeIdle(timestamp long) : int in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Inline Method | 1 | ||
| Inline Method private acquireConnection(waiter Waiter<C>) : boolean inlined to private nextTask() : Runnable in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Change Return Type | 6 | ||
| Change Return Type void to boolean in method package onGoAwayReceived(lastStreamId int, errorCode long, debugData ByteBuf) : boolean in class io.vertx.core.http.impl.Http2ConnectionBase | From | To | |
| Change Return Type void to boolean in method private recycleConnection(holder Holder, timestamp long) : boolean in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Change Return Type void to boolean in method package onGoAwayReceived(lastStreamId int, errorCode long, debugData ByteBuf) : boolean in class io.vertx.core.http.impl.Http2ClientConnection | From | To | |
| Change Return Type void to Runnable in method private nextTask() : Runnable in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Change Return Type void to boolean in method package onGoAwaySent(lastStreamId int, errorCode long, debugData ByteBuf) : boolean in class io.vertx.core.http.impl.Http2ClientConnection | From | To | |
| Change Return Type void to boolean in method package onGoAwaySent(lastStreamId int, errorCode long, debugData ByteBuf) : boolean in class io.vertx.core.http.impl.Http2ConnectionBase | From | To | |
| Move Attribute | 3 | ||
| Move Attribute package context : ContextInternal from class io.vertx.core.http.impl.pool.Pool.Holder to private context : ContextInternal from class io.vertx.core.http.impl.pool.Pool | From | To | |
| Move Attribute private context : ContextInternal from class io.vertx.core.http.impl.pool.ConnectResult to private context : ContextInternal from class io.vertx.core.http.impl.pool.Pool | From | To | |
| Move Attribute public context : ContextInternal from class io.vertx.core.http.impl.pool.Waiter to private context : ContextInternal from class io.vertx.core.http.impl.pool.Pool | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute maxPoolSize : int to poolMaxSize : int in class io.vertx.core.net.ConnectionPoolTest.FakeConnectionManager | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type copy : List<Holder<C>> to toClose : List<C> in method public closeIdle(timestamp long) : int in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Change Variable Type conn : Holder<C> to conn : C in method public closeIdle(timestamp long) : int in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Change Variable Type conn : Holder<C> to conn : Holder in method private nextTask() : Runnable in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Extract Method | 2 | ||
| Extract Method private canClose() : boolean extracted from private checkClose() : void in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Extract Method private canAcquireConnection() : boolean extracted from private checkPending() : void in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type available : Deque<Holder<C>> to available : Deque<Holder> in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Change Attribute Type connectionRemoved : BiConsumer<Channel,C> to connectionRemoved : Consumer<C> in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Change Attribute Type connectionAdded : BiConsumer<Channel,C> to connectionAdded : Consumer<C> in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Change Attribute Type waitersQueue : Queue<Waiter<C>> to waitersQueue : Deque<Waiter<C>> in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter conn : Holder<C> to holder : Holder in method private recycleConnection(holder Holder, timestamp long) : boolean in class io.vertx.core.http.impl.pool.Pool | From | To | |
| Rename Parameter maxPoolSize : int to poolMaxSize : int in method package FakeConnectionManager(queueMaxSize int, poolMaxSize int, connector ConnectionProvider<FakeConnection>, fifo boolean) in class io.vertx.core.net.ConnectionPoolTest.FakeConnectionManager | From | To | |
| Rename Parameter maxPoolSize : int to poolMaxSize : int in method package FakeConnectionManager(queueMaxSize int, poolMaxSize int, connector ConnectionProvider<FakeConnection>) in class io.vertx.core.net.ConnectionPoolTest.FakeConnectionManager | From | To |