645f6d4d41e0301155501b1e287ac49d6e60573b
Files Diff
- Added: 2
- Removed: 1
- Renamed: 0
- Modified: 44
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method private checkEnded() : void renamed to private checkValid() : void in class io.vertx.core.http.impl.Http2ServerResponseImpl | From | To | |
| Rename Method private writeTextMessageInternal(text String) : void renamed to public writeTextMessage(text String, handler Handler<AsyncResult<Void>>) : S in class io.vertx.core.http.impl.WebSocketImplBase | From | To | |
| Rename Method private writeMessageInternal(data Buffer) : void renamed to public writeBinaryMessage(data Buffer, handler Handler<AsyncResult<Void>>) : S in class io.vertx.core.http.impl.WebSocketImplBase | From | To | |
| Rename Method private end(chunk ByteBuf) : void renamed to package write(chunk ByteBuf, end boolean, handler Handler<AsyncResult<Void>>) : void in class io.vertx.core.http.impl.Http2ServerResponseImpl | From | To | |
| Pull Up Method | 2 | ||
| Pull Up Method public close() : void from class io.vertx.core.http.impl.Http1xClientConnection to public close(handler Handler<AsyncResult<Void>>) : void from class io.vertx.core.http.impl.Http1xConnectionBase | From | To | |
| Pull Up Method public close() : void from class io.vertx.core.http.impl.Http1xServerConnection to public close(handler Handler<AsyncResult<Void>>) : void from class io.vertx.core.http.impl.Http1xConnectionBase | From | To | |
| Inline Method | 1 | ||
| Inline Method package write(chunk ByteBuf, end boolean) : void inlined to package write(chunk ByteBuf, end boolean, handler Handler<AsyncResult<Void>>) : void in class io.vertx.core.http.impl.Http2ServerResponseImpl | From | To | |
| Rename Variable | 1 | ||
| Rename Variable data : T to msg : MessageImpl<T,?> in method private doReceiveCredit(credit int) : void in class io.vertx.core.eventbus.impl.MessageProducerImpl | From | To | |
| Change Return Type | 6 | ||
| Change Return Type boolean to ReplyException in method protected deliverMessageLocally(msg MessageImpl) : ReplyException in class io.vertx.core.eventbus.impl.EventBusImpl | From | To | |
| Change Return Type HttpClientRequestImpl to HttpClientRequest in method public write(chunk String) : HttpClientRequest in class io.vertx.core.http.impl.HttpClientRequestImpl | From | To | |
| Change Return Type HttpClientRequestImpl to HttpClientRequest in method public write(chunk Buffer) : HttpClientRequest in class io.vertx.core.http.impl.HttpClientRequestImpl | From | To | |
| Change Return Type void to S in method public writeTextMessage(text String, handler Handler<AsyncResult<Void>>) : S in class io.vertx.core.http.impl.WebSocketImplBase | From | To | |
| Change Return Type HttpClientRequestImpl to HttpClientRequest in method public write(chunk String, enc String) : HttpClientRequest in class io.vertx.core.http.impl.HttpClientRequestImpl | From | To | |
| Change Return Type void to S in method public writeBinaryMessage(data Buffer, handler Handler<AsyncResult<Void>>) : S in class io.vertx.core.http.impl.WebSocketImplBase | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class io.vertx.core.datagram.impl.DatagramChannelFutureListener moved and renamed to io.vertx.core.net.impl.ChannelFutureListenerAdapter | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type data : T to msg : MessageImpl<T,?> in method private doReceiveCredit(credit int) : void in class io.vertx.core.eventbus.impl.MessageProducerImpl | From | To | |
| Extract Method | 31 | ||
| Extract Method public write(data T, handler Handler<AsyncResult<Void>>) : MessageProducer<T> extracted from public write(data T) : MessageProducer<T> in class io.vertx.core.eventbus.impl.MessageProducerImpl | From | To | |
| Extract Method public writeFinalBinaryFrame(data Buffer, handler Handler<AsyncResult<Void>>) : S extracted from public writeFinalBinaryFrame(data Buffer) : S in class io.vertx.core.http.impl.WebSocketImplBase | From | To | |
| Extract Method public write(chunk String, handler Handler<AsyncResult<Void>>) : HttpClientRequest extracted from public write(chunk String) : HttpClientRequestImpl in class io.vertx.core.http.impl.HttpClientRequestImpl | From | To | |
| Extract Method public write(data Buffer, handler Handler<AsyncResult<Void>>) : S extracted from public write(data Buffer) : S in class io.vertx.core.http.impl.WebSocketImplBase | From | To | |
| Extract Method public write(str String, handler Handler<AsyncResult<Void>>) : NetSocket extracted from public write(str String) : NetSocket in class io.vertx.core.net.impl.NetSocketImpl | From | To | |
| Extract Method private testCloseStatusCodeFromServer(closeOp Consumer<ServerWebSocket>) : void extracted from public testCloseStatusCodeFromServer() : void in class io.vertx.core.http.WebSocketTest | From | To | |
| Extract Method private testCloseCustomPayloadFromServer(closeOp Consumer<ServerWebSocket>) : void extracted from public testCloseCustomPayloadFromServer() : void in class io.vertx.core.http.WebSocketTest | From | To | |
| Extract Method public writeFrame(frame WebSocketFrame, handler Handler<AsyncResult<Void>>) : S extracted from public writeFrame(frame WebSocketFrame) : S in class io.vertx.core.http.impl.WebSocketImplBase | From | To | |
| Extract Method public write(chunk Buffer, handler Handler<AsyncResult<Void>>) : HttpClientRequest extracted from public write(chunk Buffer) : HttpClientRequestImpl in class io.vertx.core.http.impl.HttpClientRequestImpl | From | To | |
| Extract Method protected startNodes(options VertxOptions...) : void extracted from protected startNodes(numNodes int, options VertxOptions) : void in class io.vertx.test.core.VertxTestBase | From | To | |
| Extract Method public close(handler Handler<AsyncResult<Void>>) : void extracted from public close() : void in class io.vertx.core.net.impl.ConnectionBase | From | To | |
| Extract Method public end(chunk String, handler Handler<AsyncResult<Void>>) : void extracted from public end(chunk String) : void in class io.vertx.core.http.impl.HttpClientRequestImpl | From | To | |
| Extract Method private createPromise(handler Handler<AsyncResult<Void>>) : ChannelPromise extracted from package writeData(stream Http2Stream, chunk ByteBuf, end boolean, handler Handler<AsyncResult<Void>>) : void in class io.vertx.core.http.impl.VertxHttp2ConnectionHandler | From | To | |
| Extract Method public write(str String, enc String, handler Handler<AsyncResult<Void>>) : NetSocket extracted from public write(str String, enc String) : NetSocket in class io.vertx.core.http.impl.VertxHttp2NetSocket | From | To | |
| Extract Method public end(chunk Buffer, handler Handler<AsyncResult<Void>>) : void extracted from public end(chunk Buffer) : void in class io.vertx.core.http.impl.Http2ServerResponseImpl | From | To | |
| Extract Method public end(chunk String, enc String, handler Handler<AsyncResult<Void>>) : void extracted from public end(chunk String, enc String) : void in class io.vertx.core.http.impl.HttpClientRequestImpl | From | To | |
| Extract Method public close(statusCode short, reason String, handler Handler<AsyncResult<Void>>) : void extracted from public close(statusCode short, reason String) : void in class io.vertx.core.http.impl.WebSocketImplBase | From | To | |
| Extract Method public write(chunk String, handler Handler<AsyncResult<Void>>) : HttpServerResponse extracted from public write(chunk String) : HttpServerResponseImpl in class io.vertx.core.http.impl.HttpServerResponseImpl | From | To | |
| Extract Method public close(handler Handler<AsyncResult<Void>>) : void extracted from public close() : void in class io.vertx.core.eventbus.impl.MessageProducerImpl | From | To | |
| Extract Method private end(chunk Buffer, promise ChannelPromise) : void extracted from public end(chunk Buffer) : void in class io.vertx.core.http.impl.HttpServerResponseImpl | From | To | |
| Extract Method private close(cause Throwable) : void extracted from package close() : void in class io.vertx.core.eventbus.impl.clustered.ConnectionHolder | From | To | |
| Extract Method public end(chunk String, handler Handler<AsyncResult<Void>>) : void extracted from public end(chunk Buffer) : void in class io.vertx.core.http.impl.Http2ServerResponseImpl | From | To | |
| Extract Method public end(chunk String, handler Handler<AsyncResult<Void>>) : void extracted from public end() : void in class io.vertx.core.http.impl.Http2ServerResponseImpl | From | To | |
| Extract Method public writeFinalTextFrame(text String, handler Handler<AsyncResult<Void>>) : S extracted from public writeFinalTextFrame(text String) : S in class io.vertx.core.http.impl.WebSocketImplBase | From | To | |
| Extract Method private testCloseCustomPayloadFromClient(closeOp Consumer<WebSocket>) : void extracted from public testCloseCustomPayloadFromClient() : void in class io.vertx.core.http.WebSocketTest | From | To | |
| Extract Method public write(chunk String, enc String, handler Handler<AsyncResult<Void>>) : HttpClientRequest extracted from public write(chunk String, enc String) : HttpClientRequestImpl in class io.vertx.core.http.impl.HttpClientRequestImpl | From | To | |
| Extract Method public write(chunk String, handler Handler<AsyncResult<Void>>) : HttpServerResponse extracted from public write(chunk String, enc String) : HttpServerResponseImpl in class io.vertx.core.http.impl.HttpServerResponseImpl | From | To | |
| Extract Method public close(statusCode short, handler Handler<AsyncResult<Void>>) : void extracted from public close(statusCode short) : void in class io.vertx.core.http.impl.WebSocketImplBase | From | To | |
| Extract Method public close(handler Handler<AsyncResult<Void>>) : void extracted from public close() : void in class io.vertx.core.http.impl.WebSocketImplBase | From | To | |
| Extract Method public write(str String, enc String, handler Handler<AsyncResult<Void>>) : NetSocket extracted from public write(str String, enc String) : NetSocket in class io.vertx.core.net.impl.NetSocketImpl | From | To | |
| Extract Method public write(buffer Buffer, handler Handler<AsyncResult<Void>>) : AsyncFile extracted from public write(buffer Buffer) : AsyncFile in class io.vertx.core.file.impl.AsyncFileImpl | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type bus : EventBus to bus : EventBusImpl in class io.vertx.core.eventbus.impl.MessageProducerImpl | From | To | |
| Change Attribute Type pending : Queue<T> to pending : Queue<MessageImpl<T,?>> in class io.vertx.core.eventbus.impl.MessageProducerImpl | From | To | |
| Extract And Move Method | 9 | ||
| Extract And Move Method public end(chunk Buffer, handler Handler<AsyncResult<Void>>) : void extracted from public end() : void in class io.vertx.core.http.impl.Http2ServerResponseImpl & moved to class io.vertx.core.http.impl.HttpServerResponseImpl | From | To | |
| Extract And Move Method public write(chunk String, enc String, handler Handler<AsyncResult<Void>>) : HttpServerResponse extracted from public write(str String) : NetSocket in class io.vertx.core.http.impl.VertxHttp2NetSocket & moved to class io.vertx.core.http.impl.HttpServerResponseImpl | From | To | |
| Extract And Move Method public write(str String, handler Handler<AsyncResult<Void>>) : NetSocket extracted from public write(chunk String) : HttpServerResponseImpl in class io.vertx.core.http.impl.HttpServerResponseImpl & moved to class io.vertx.core.http.impl.VertxHttp2NetSocket | From | To | |
| Extract And Move Method public write(chunk String, handler Handler<AsyncResult<Void>>) : HttpClientRequest extracted from public write(chunk String, enc String) : HttpServerResponseImpl in class io.vertx.core.http.impl.HttpServerResponseImpl & moved to class io.vertx.core.http.impl.HttpClientRequestImpl | From | To | |
| Extract And Move Method public write(str String, handler Handler<AsyncResult<Void>>) : NetSocket extracted from public write(chunk String, enc String) : HttpServerResponseImpl in class io.vertx.core.http.impl.HttpServerResponseImpl & moved to class io.vertx.core.http.impl.VertxHttp2NetSocket | From | To | |
| Extract And Move Method public write(chunk String, enc String, handler Handler<AsyncResult<Void>>) : HttpServerResponse extracted from public write(str String) : NetSocket in class io.vertx.core.http.impl.VertxHttp2NetSocket & moved to class io.vertx.core.http.impl.Http2ServerResponseImpl | From | To | |
| Extract And Move Method public end(data T, handler Handler<AsyncResult<Void>>) : void extracted from public end() : void in class io.vertx.core.http.impl.Http2ServerResponseImpl & moved to class io.vertx.core.streams.WriteStream | From | To | |
| Extract And Move Method public write(chunk String, handler Handler<AsyncResult<Void>>) : HttpClientRequest extracted from public write(chunk String) : HttpServerResponseImpl in class io.vertx.core.http.impl.HttpServerResponseImpl & moved to class io.vertx.core.http.impl.HttpClientRequestImpl | From | To | |
| Extract And Move Method public end(data T, handler Handler<AsyncResult<Void>>) : void extracted from public end(chunk Buffer) : void in class io.vertx.core.http.impl.Http2ServerResponseImpl & moved to class io.vertx.core.streams.WriteStream | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter t : T to data : T in method public end(data T) : void in class io.vertx.core.streams.WriteStream | From | To |