vert.x 8965822c11828b4e69baee911f315901c2e073ec

8965822c11828b4e69baee911f315901c2e073ec

Files Diff

Added: 5
Removed: 2
Renamed: 0
Modified: 31

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method private loadPrivateKey(key Buffer) : PrivateKey renamed to private loadCerts(cert Buffer) : X509Certificate[] in class io.vertx.core.net.impl.KeyStoreHelper	From	To
Move And Rename Method	1
Move And Rename Method private testTLS(clientCert KeyCert, clientTrust Trust, serverCert KeyCert, serverTrust Trust, requireClientAuth boolean, serverUsesCrl boolean, clientTrustAll boolean, clientUsesCrl boolean, shouldPass boolean, enabledCipherSuites String...) : void from class io.vertx.test.core.Http1xTest to package run(shouldPass boolean) : void from class io.vertx.test.core.HttpTLSTest.TLSTest	From	To
Change Parameter Type	6
Change Parameter Type clientTrust : Trust to clientTrust : TLSCert in method private testTLS(clientCert TLSCert, clientTrust TLSCert, serverCert TLSCert, serverTrust TLSCert, requireClientAuth boolean, serverUsesCrl boolean, clientTrustAll boolean, clientUsesCrl boolean, shouldPass boolean, enabledCipherSuites String...) : void in class io.vertx.test.core.WebsocketTest	From	To
Change Parameter Type serverTrust : Trust to serverTrust : TLSCert in method private testTLS(clientCert TLSCert, clientTrust TLSCert, serverCert TLSCert, serverTrust TLSCert, requireClientAuth boolean, serverUsesCrl boolean, clientTrustAll boolean, clientUsesCrl boolean, shouldPass boolean, enabledCipherSuites String...) : void in class io.vertx.test.core.WebsocketTest	From	To
Change Parameter Type clientCert : KeyCert to clientCert : TLSCert in method private testTLS(clientCert TLSCert, clientTrust TLSCert, serverCert TLSCert, serverTrust TLSCert, requireClientAuth boolean, serverUsesCrl boolean, clientTrustAll boolean, clientUsesCrl boolean, shouldPass boolean, enabledCipherSuites String...) : void in class io.vertx.test.core.WebsocketTest	From	To
Change Parameter Type cert : KeyCert to cert : TLSCert in method public ClusteredEventBusWithSSLTest(cert TLSCert, trust TLSCert, requireClientAuth boolean, clientTrustAll boolean, useCrl boolean, enabledCipherSuites List<String>) in class io.vertx.test.core.ClusteredEventBusWithSSLTest	From	To
Change Parameter Type serverCert : KeyCert to serverCert : TLSCert in method private testTLS(clientCert TLSCert, clientTrust TLSCert, serverCert TLSCert, serverTrust TLSCert, requireClientAuth boolean, serverUsesCrl boolean, clientTrustAll boolean, clientUsesCrl boolean, shouldPass boolean, enabledCipherSuites String...) : void in class io.vertx.test.core.WebsocketTest	From	To
Change Parameter Type trust : Trust to trust : TLSCert in method public ClusteredEventBusWithSSLTest(cert TLSCert, trust TLSCert, requireClientAuth boolean, clientTrustAll boolean, useCrl boolean, enabledCipherSuites List<String>) in class io.vertx.test.core.ClusteredEventBusWithSSLTest	From	To
Move Method	48
Move Method public testCaInvalidPath() : void from class io.vertx.test.core.Http1xTest to public testCaInvalidPath() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientTrustServerCertPKCS12() : void from class io.vertx.test.core.Http1xTest to public testTLSClientTrustServerCertPKCS12() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testPKCS12InvalidPath() : void from class io.vertx.test.core.Http1xTest to public testPKCS12InvalidPath() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testKeyCertInvalidPem() : void from class io.vertx.test.core.Http1xTest to public testKeyCertInvalidPem() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientTrustAll() : void from class io.vertx.test.core.Http1xTest to public testTLSClientTrustAll() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientCertPEMRequired() : void from class io.vertx.test.core.Http1xTest to public testTLSClientCertPEMRequired() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method private testInvalidTrustStore(options TrustOptions, expectedPrefix String, expectedSuffix String) : void from class io.vertx.test.core.Http1xTest to private testInvalidTrustStore(options TrustOptions, expectedPrefix String, expectedSuffix String) : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientCertPEM_CARequired() : void from class io.vertx.test.core.Http1xTest to public testTLSClientCertPEM_CARequired() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientTrustPKCS12ServerCert() : void from class io.vertx.test.core.Http1xTest to public testTLSClientTrustPKCS12ServerCert() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientTrustServerCertPEM_CAWithJKS_CA() : void from class io.vertx.test.core.Http1xTest to public testTLSClientTrustServerCertPEM_CAWithJKS_CA() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientCertRequiredNoClientCert() : void from class io.vertx.test.core.Http1xTest to public testTLSClientCertRequiredNoClientCert() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientTrustServerCertPEM() : void from class io.vertx.test.core.Http1xTest to public testTLSClientTrustServerCertPEM() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testJKSInvalidPath() : void from class io.vertx.test.core.Http1xTest to public testJKSInvalidPath() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientTrustServerCertPKCS12_CAWithPEM_CA() : void from class io.vertx.test.core.Http1xTest to public testTLSClientTrustServerCertPKCS12_CAWithPEM_CA() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testJKSInvalidPassword() : void from class io.vertx.test.core.Http1xTest to public testJKSInvalidPassword() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testKeyCertMissingKeyPath() : void from class io.vertx.test.core.Http1xTest to public testKeyCertMissingKeyPath() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testKeyCertMissingCertPath() : void from class io.vertx.test.core.Http1xTest to public testKeyCertMissingCertPath() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientUntrustedServerPEM() : void from class io.vertx.test.core.Http1xTest to public testTLSClientUntrustedServerPEM() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method private testInvalidKeyStore(options KeyCertOptions, expectedPrefix String, expectedSuffix String) : void from class io.vertx.test.core.Http1xTest to private testInvalidKeyStore(options KeyCertOptions, expectedPrefix String, expectedSuffix String) : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method private testInvalidKeyStore(options KeyCertOptions, expectedPossiblePrefixes List<String>, expectedSuffix String) : void from class io.vertx.test.core.Http1xTest to private testInvalidKeyStore(options KeyCertOptions, expectedPossiblePrefixes List<String>, expectedSuffix String) : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientTrustServerCertJKS_CAWithJKS_CA() : void from class io.vertx.test.core.Http1xTest to public testTLSClientTrustServerCertJKS_CAWithJKS_CA() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientTrustServerCertPKCS12_CAWithPKCS12_CA() : void from class io.vertx.test.core.Http1xTest to public testTLSClientTrustServerCertPKCS12_CAWithPKCS12_CA() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientCertNotRequired() : void from class io.vertx.test.core.Http1xTest to public testTLSClientCertNotRequired() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientCertNotRequiredPEM() : void from class io.vertx.test.core.Http1xTest to public testTLSClientCertNotRequiredPEM() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientTrustServerCertPEM_CAWithPKCS12_CA() : void from class io.vertx.test.core.Http1xTest to public testTLSClientTrustServerCertPEM_CAWithPKCS12_CA() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientCertClientNotTrusted() : void from class io.vertx.test.core.Http1xTest to public testTLSClientCertClientNotTrusted() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientCertRequired() : void from class io.vertx.test.core.Http1xTest to public testTLSClientCertRequired() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSRevokedClientCertServer() : void from class io.vertx.test.core.Http1xTest to public testTLSRevokedClientCertServer() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientTrustServerCertJKS_CAWithPKCS12_CA() : void from class io.vertx.test.core.Http1xTest to public testTLSClientTrustServerCertJKS_CAWithPKCS12_CA() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testCaInvalidPem() : void from class io.vertx.test.core.Http1xTest to public testCaInvalidPem() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientTrustServerCert() : void from class io.vertx.test.core.Http1xTest to public testTLSClientTrustServerCert() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testPKCS12MissingPassword() : void from class io.vertx.test.core.Http1xTest to public testPKCS12MissingPassword() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientTrustPEMServerCert() : void from class io.vertx.test.core.Http1xTest to public testTLSClientTrustPEMServerCert() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientTrustServerCertPEM_CAWithPEM_CA() : void from class io.vertx.test.core.Http1xTest to public testTLSClientTrustServerCertPEM_CAWithPEM_CA() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientUntrustedServer() : void from class io.vertx.test.core.Http1xTest to public testTLSClientUntrustedServer() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientCertPKCS12Required() : void from class io.vertx.test.core.Http1xTest to public testTLSClientCertPKCS12Required() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSCipherSuites() : void from class io.vertx.test.core.Http1xTest to public testTLSCipherSuites() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testJKSMissingPassword() : void from class io.vertx.test.core.Http1xTest to public testJKSMissingPassword() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testKeyCertInvalidKeyPath() : void from class io.vertx.test.core.Http1xTest to public testKeyCertInvalidKeyPath() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientRevokedServerCert() : void from class io.vertx.test.core.Http1xTest to public testTLSClientRevokedServerCert() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientCertRequiredPEM() : void from class io.vertx.test.core.Http1xTest to public testTLSClientCertRequiredPEM() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testPKCS12InvalidPassword() : void from class io.vertx.test.core.Http1xTest to public testPKCS12InvalidPassword() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientTrustServerCertJKS_CAWithPEM_CA() : void from class io.vertx.test.core.Http1xTest to public testTLSClientTrustServerCertJKS_CAWithPEM_CA() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientTrustServerCertPKCS12_CAWithJKS_CA() : void from class io.vertx.test.core.Http1xTest to public testTLSClientTrustServerCertPKCS12_CAWithJKS_CA() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method private testStore(serverOptions HttpServerOptions, expectedPossiblePrefixes List<String>, expectedSuffix String) : void from class io.vertx.test.core.Http1xTest to private testStore(serverOptions HttpServerOptions, expectedPossiblePrefixes List<String>, expectedSuffix String) : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testTLSClientCertRequiredPKCS12() : void from class io.vertx.test.core.Http1xTest to public testTLSClientCertRequiredPKCS12() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testCrlInvalidPath() : void from class io.vertx.test.core.Http1xTest to public testCrlInvalidPath() : void from class io.vertx.test.core.HttpTLSTest	From	To
Move Method public testKeyCertInvalidCertPath() : void from class io.vertx.test.core.Http1xTest to public testKeyCertInvalidCertPath() : void from class io.vertx.test.core.HttpTLSTest	From	To
Rename Variable	2
Rename Variable rsaKeyFactory : KeyFactory to certFactory : CertificateFactory in method private loadCerts(cert Buffer) : X509Certificate[] in class io.vertx.core.net.impl.KeyStoreHelper	From	To
Rename Variable trustMgrs : TrustManager[] to fact : TrustManagerFactory in method private getTrustMgrFactory(vertx VertxInternal) : TrustManagerFactory in class io.vertx.core.net.impl.SSLHelper	From	To
Change Return Type	3
Change Return Type PrivateKey to X509Certificate[] in method private loadCerts(cert Buffer) : X509Certificate[] in class io.vertx.core.net.impl.KeyStoreHelper	From	To
Change Return Type SSLContext to SslContext in method private getContext(vertx VertxInternal) : SslContext in class io.vertx.core.net.impl.SSLHelper	From	To
Change Return Type SSLContext to SslContext in method private createContext(vertx VertxInternal) : SslContext in class io.vertx.core.net.impl.SSLHelper	From	To
Extract Class	1
Extract Class io.vertx.test.core.HttpTLSTest from class io.vertx.test.core.Http1xTest	From	To
Rename Class	1
Rename Class io.vertx.test.core.Trust renamed to io.vertx.test.core.TLSCert	From	To
Move And Rename Class	1
Move And Rename Class io.vertx.test.core.KeyCert moved and renamed to io.vertx.core.net.SSLEngine	From	To
Change Variable Type	2
Change Variable Type rsaKeyFactory : KeyFactory to certFactory : CertificateFactory in method private loadCerts(cert Buffer) : X509Certificate[] in class io.vertx.core.net.impl.KeyStoreHelper	From	To
Change Variable Type trustMgrs : TrustManager[] to fact : TrustManagerFactory in method private getTrustMgrFactory(vertx VertxInternal) : TrustManagerFactory in class io.vertx.core.net.impl.SSLHelper	From	To
Change Attribute Type	1
Change Attribute Type sslContext : SSLContext to sslContext : SslContext in class io.vertx.core.net.impl.SSLHelper	From	To
Extract Method	6
Extract Method private getKeyMgrFactory(vertx VertxInternal) : KeyManagerFactory extracted from private createContext(vertx VertxInternal) : SSLContext in class io.vertx.core.net.impl.SSLHelper	From	To
Extract Method public getTrustMgrFactory(vertx VertxInternal) : TrustManagerFactory extracted from public getTrustMgrs(vertx VertxInternal) : TrustManager[] in class io.vertx.core.net.impl.KeyStoreHelper	From	To
Extract Method private handshakeFailure(context ContextImpl, ch Channel, cause Throwable, waiter Waiter) : void extracted from protected internalConnect(host String, port int, waiter Waiter) : void in class io.vertx.core.http.impl.ConnectionManager.ConnQueue	From	To
Extract Method public getKeyMgrFactory(vertx VertxInternal) : KeyManagerFactory extracted from public getKeyMgrs(vertx VertxInternal) : KeyManager[] in class io.vertx.core.net.impl.KeyStoreHelper	From	To
Extract Method private getTrustMgrFactory(vertx VertxInternal) : TrustManagerFactory extracted from private createContext(vertx VertxInternal) : SSLContext in class io.vertx.core.net.impl.SSLHelper	From	To
Rename Parameter	1
Rename Parameter key : Buffer to cert : Buffer in method private loadCerts(cert Buffer) : X509Certificate[] in class io.vertx.core.net.impl.KeyStoreHelper	From	To

8965822c11828b4e69baee911f315901c2e073ec

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: